Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-18 02:46:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

block: sed-opal: unify error handling of responses

Browse Source 
response_get_{string,u64} include error handling for argument resp being
NULL but response_get_token does not handle this.

Make all three of response_get_{string,u64,token} handle NULL resp in
the same way.

Co-authored-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Signed-off-by: David Kozub <zub@linux.fjfi.cvut.cz>
Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Reviewed-by: Scott Bauer <sbauer@plzdonthack.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jon Derrick <jonathan.derrick@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
David Kozub 2019-02-14 01:15:59 +01:00 committed by Jens Axboe
parent e8b2922459
commit 7d9b62ae2a
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
block/sed-opal.c
View File

@ -696,6 +696,11 @@ static const struct opal_resp_tok *response_get_token(
{ {
const struct opal_resp_tok *tok; const struct opal_resp_tok *tok;
if (!resp) {
pr_debug("Response is NULL\n");
return ERR_PTR(-EINVAL);
}
if (n >= resp->num) { if (n >= resp->num) {
pr_debug("Token number doesn't exist: %d, resp: %d\n", pr_debug("Token number doesn't exist: %d, resp: %d\n",
n, resp->num); n, resp->num);