Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-19 20:05:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

dt-bindings: mailbox: mpfs: fix reg properties

Browse Source 
When the binding for this was originally written, and later modified,
mistakes were made - and the precise nature of the later modification
should have been a giveaway, but alas I was naive at the time.

A more correct modelling of the hardware is to use two syscons and have
a single reg entry for the mailbox, containing the mailbox region. The
two syscons contain the general control/status registers for the mailbox
and the interrupt related registers respectively. The reason for two
syscons is that the same mailbox is present on the non-SoC version of
the FPGA, which has no interrupt controller, and the shared part of the
rtl was unchanged between devices.

This is now coming to a head, because the control/status registers share
a register region with the "tvs" (temperature & voltage sensors)
registers and, as it turns out, people do want to monitor temperatures
and voltages...

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
This commit is contained in:
Conor Dooley 2024-10-02 11:47:59 +01:00 committed by Jassi Brar
parent 2d5404caa8
commit 8edd00b06f
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml
View File

@ -15,6 +15,8 @@ properties:
reg: reg:
oneOf: oneOf:
- items:
- description: mailbox data registers
- items: - items:
- description: mailbox control & data registers - description: mailbox control & data registers
- description: mailbox interrupt registers - description: mailbox interrupt registers
@ -23,6 +25,7 @@ properties:
- description: mailbox control registers - description: mailbox control registers
- description: mailbox interrupt registers - description: mailbox interrupt registers
- description: mailbox data registers - description: mailbox data registers
deprecated: true
interrupts: interrupts:
maxItems: 1 maxItems: 1
@ -41,12 +44,12 @@ additionalProperties: false
examples: examples:
- | - |
soc { soc {
#address-cells = <2>; #address-cells = <1>;
#size-cells = <2>; #size-cells = <1>;
mbox: mailbox@37020000 {
mailbox@37020800 {
compatible = "microchip,mpfs-mailbox"; compatible = "microchip,mpfs-mailbox";
reg = <0x0 0x37020000 0x0 0x58>, <0x0 0x2000318C 0x0 0x40>, reg = <0x37020800 0x100>;
<0x0 0x37020800 0x0 0x100>;
interrupt-parent = <&L1>; interrupt-parent = <&L1>;
interrupts = <96>; interrupts = <96>;
#mbox-cells = <1>; #mbox-cells = <1>;