Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2024-12-29 01:03:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

memblock: allow zero threshold in validate_numa_converage()

Browse Source 
Currently memblock validate_numa_converage() returns false negative when
threshold set to zero.

Make the check if the memory size with invalid node ID is greater than
the threshold exclusive to fix that.

Link: https://lore.kernel.org/all/Z0mIDBD4KLyxyOCm@kernel.org/
Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
This commit is contained in:
Mike Rapoport (Microsoft) 2024-11-29 11:13:47 +02:00
parent bcc8eda6d3
commit 9cdc6423ac
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mm/memblock.c
View File

@ -735,7 +735,7 @@ int __init_memblock memblock_add(phys_addr_t base, phys_addr_t size)
/** /**
* memblock_validate_numa_coverage - check if amount of memory with * memblock_validate_numa_coverage - check if amount of memory with
* no node ID assigned is less than a threshold * no node ID assigned is less than a threshold
* @threshold_bytes: maximal number of pages that can have unassigned node * @threshold_bytes: maximal memory size that can have unassigned node
* ID (in bytes). * ID (in bytes).
* *
* A buggy firmware may report memory that does not belong to any node. * A buggy firmware may report memory that does not belong to any node.
@ -755,7 +755,7 @@ bool __init_memblock memblock_validate_numa_coverage(unsigned long threshold_byt
nr_pages += end_pfn - start_pfn; nr_pages += end_pfn - start_pfn;
} }
if ((nr_pages << PAGE_SHIFT) >= threshold_bytes) { if ((nr_pages << PAGE_SHIFT) > threshold_bytes) {
mem_size_mb = memblock_phys_mem_size() >> 20; mem_size_mb = memblock_phys_mem_size() >> 20;
pr_err("NUMA: no nodes coverage for %luMB of %luMB RAM\n", pr_err("NUMA: no nodes coverage for %luMB of %luMB RAM\n",
(nr_pages << PAGE_SHIFT) >> 20, mem_size_mb); (nr_pages << PAGE_SHIFT) >> 20, mem_size_mb);