Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-18 10:56:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

scsi: report 'INQUIRY result too short' once per host

Browse Source 
Some host adapters (e.g. Hyper-V storvsc) are known for not respecting
the SPC-2/3/4 requirement for 'INQUIRY data (see table ...) shall
contain at least 36 bytes'. As a result we get tons on 'scsi 0:7:1:1:
scsi scan: INQUIRY result too short (5), using 36' messages on
console. This can be problematic for slow consoles. Introduce
short_inquiry flag in struct Scsi_Host to print the message once per
host.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Vitaly Kuznetsov 2015-11-19 14:17:06 +01:00 committed by Martin K. Petersen
parent 757b22f9d5
commit a35bb4458e
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/scsi/scsi_scan.c
View File

@ -702,9 +702,12 @@ static int scsi_probe_lun(struct scsi_device *sdev, unsigned char *inq_result,
* strings. * strings.
*/ */
if (sdev->inquiry_len < 36) { if (sdev->inquiry_len < 36) {
sdev_printk(KERN_INFO, sdev, if (!sdev->host->short_inquiry) {
"scsi scan: INQUIRY result too short (%d)," shost_printk(KERN_INFO, sdev->host,
" using 36\n", sdev->inquiry_len); "scsi scan: INQUIRY result too short (%d),"
" using 36\n", sdev->inquiry_len);
sdev->host->short_inquiry = 1;
}
sdev->inquiry_len = 36; sdev->inquiry_len = 36;
} }

3
include/scsi/scsi_host.h
View File

@ -673,6 +673,9 @@ struct Scsi_Host {
unsigned use_blk_mq:1; unsigned use_blk_mq:1;
unsigned use_cmd_list:1; unsigned use_cmd_list:1;
/* Host responded with short (<36 bytes) INQUIRY result */
unsigned short_inquiry:1;
/* /*
* Optional work queue to be utilized by the transport * Optional work queue to be utilized by the transport
*/ */