Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-13 00:29:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pnp: avoid a small unlikely memory leak in proc_read_escd()

Browse Source 
There's a small and unlikely memory leak in
drivers/pnp/pnpbios/proc.c::proc_read_escd().  It's inside a sanity check,
so it probably won't trigger often (if at all), however it *is* a potential
leak and it's easy to avoid, so let's just fix it :)

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jesper Juhl 2007-10-16 23:26:56 -07:00 committed by Linus Torvalds
parent 5f149cf0ac
commit a8b0ac0873
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/pnp/pnpbios/proc.c
View File

@ -94,8 +94,9 @@ static int proc_read_escd(char *buf, char **start, off_t pos,
/* sanity check */ /* sanity check */
if (escd_size > MAX_SANE_ESCD_SIZE) { if (escd_size > MAX_SANE_ESCD_SIZE) {
printk(KERN_ERR printk(KERN_ERR "PnPBIOS: proc_read_escd: ESCD size reported by"
"PnPBIOS: proc_read_escd: ESCD size reported by BIOS read_escd call is too great\n"); " BIOS read_escd call is too great\n");
kfree(tmpbuf);
return -EFBIG; return -EFBIG;
} }