Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-01 10:43:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path

Browse Source 
For blkcg_css_alloc(), the only error that will be returned is -ENOMEM.
Simplify error handling code by returning this error directly instead
of setting an intermediate "ret" variable.

Signed-off-by: Waiman Long <longman@redhat.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20221105005902.407297-2-longman@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Waiman Long 2022-11-04 20:59:00 -04:00 committed by Jens Axboe
parent 077a403354
commit b5a9adcbd5
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
block/blk-cgroup.c
View File

@ -1139,7 +1139,6 @@ static struct cgroup_subsys_state *
blkcg_css_alloc(struct cgroup_subsys_state *parent_css) blkcg_css_alloc(struct cgroup_subsys_state *parent_css)
{ {
struct blkcg *blkcg; struct blkcg *blkcg;
struct cgroup_subsys_state *ret;
int i; int i;
mutex_lock(&blkcg_pol_mutex); mutex_lock(&blkcg_pol_mutex);
@ -1148,10 +1147,8 @@ blkcg_css_alloc(struct cgroup_subsys_state *parent_css)
blkcg = &blkcg_root; blkcg = &blkcg_root;
} else { } else {
blkcg = kzalloc(sizeof(*blkcg), GFP_KERNEL); blkcg = kzalloc(sizeof(*blkcg), GFP_KERNEL);
if (!blkcg) { if (!blkcg)
ret = ERR_PTR(-ENOMEM);
goto unlock; goto unlock;
}
} }
for (i = 0; i < BLKCG_MAX_POLS ; i++) { for (i = 0; i < BLKCG_MAX_POLS ; i++) {
@ -1168,10 +1165,9 @@ blkcg_css_alloc(struct cgroup_subsys_state *parent_css)
continue; continue;
cpd = pol->cpd_alloc_fn(GFP_KERNEL); cpd = pol->cpd_alloc_fn(GFP_KERNEL);
if (!cpd) { if (!cpd)
ret = ERR_PTR(-ENOMEM);
goto free_pd_blkcg; goto free_pd_blkcg;
}
blkcg->cpd[i] = cpd; blkcg->cpd[i] = cpd;
cpd->blkcg = blkcg; cpd->blkcg = blkcg;
cpd->plid = i; cpd->plid = i;
@ -1200,7 +1196,7 @@ blkcg_css_alloc(struct cgroup_subsys_state *parent_css)
kfree(blkcg); kfree(blkcg);
unlock: unlock:
mutex_unlock(&blkcg_pol_mutex); mutex_unlock(&blkcg_pol_mutex);
return ret; return ERR_PTR(-ENOMEM);
} }
static int blkcg_css_online(struct cgroup_subsys_state *css) static int blkcg_css_online(struct cgroup_subsys_state *css)