Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-07 13:53:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

hpfs: remove ->writepage

Browse Source 
->writepage is a very inefficient method to write back data, and only
used through write_cache_pages or a a fallback when no ->migrate_folio
method is present.

Set ->migrate_folio to the generic buffer_head based helper, and remove
the ->writepage implementation.

Link: https://lkml.kernel.org/r/20221202102644.770505-6-hch@lst.de
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Christoph Hellwig 2022-12-02 11:26:42 +01:00 committed by Andrew Morton
parent 12f9b9a73d
commit cd2e602426
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
fs/hpfs/file.c
View File

@ -163,11 +163,6 @@ static int hpfs_read_folio(struct file *file, struct folio *folio)
return mpage_read_folio(folio, hpfs_get_block); return mpage_read_folio(folio, hpfs_get_block);
} }
static int hpfs_writepage(struct page *page, struct writeback_control *wbc)
{
return block_write_full_page(page, hpfs_get_block, wbc);
}
static void hpfs_readahead(struct readahead_control *rac) static void hpfs_readahead(struct readahead_control *rac)
{ {
mpage_readahead(rac, hpfs_get_block); mpage_readahead(rac, hpfs_get_block);
@ -248,12 +243,12 @@ const struct address_space_operations hpfs_aops = {
.dirty_folio = block_dirty_folio, .dirty_folio = block_dirty_folio,
.invalidate_folio = block_invalidate_folio, .invalidate_folio = block_invalidate_folio,
.read_folio = hpfs_read_folio, .read_folio = hpfs_read_folio,
.writepage = hpfs_writepage,
.readahead = hpfs_readahead, .readahead = hpfs_readahead,
.writepages = hpfs_writepages, .writepages = hpfs_writepages,
.write_begin = hpfs_write_begin, .write_begin = hpfs_write_begin,
.write_end = hpfs_write_end, .write_end = hpfs_write_end,
.bmap = _hpfs_bmap .bmap = _hpfs_bmap,
.migrate_folio = buffer_migrate_folio,
}; };
const struct file_operations hpfs_file_ops = const struct file_operations hpfs_file_ops =