Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-17 18:36:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

leds: max77693: Add missing of_node_get for probe duration

Browse Source 
At beginning of probe() function, the driver iterates over OF children
and assigns found device node for later.  The code uses
for_each_available_child_of_node() which drops the references on
children on each successful pass, thus the probe function operates later
on the device node without holding the reference.

Fix this by increasing the reference count for found child node and
drop it at the end of the probe, because it is not needed further (the
V4L init code takes its own references).

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240816-cleanup-h-of-node-put-var-v1-3-1d0292802470@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Krzysztof Kozlowski 2024-08-16 17:31:35 +02:00 committed by Lee Jones
parent 700b6c984b
commit d225d436f7
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/leds/flash/leds-max77693.c
View File

@ -649,7 +649,7 @@ static int max77693_led_parse_dt(struct max77693_led_device *led,
return -EINVAL; return -EINVAL;
} }
sub_nodes[fled_id] = child_node; sub_nodes[fled_id] = of_node_get(child_node);
sub_leds[fled_id].fled_id = fled_id; sub_leds[fled_id].fled_id = fled_id;
cfg->label[fled_id] = cfg->label[fled_id] =
@ -968,7 +968,7 @@ static int max77693_led_probe(struct platform_device *pdev)
ret = max77693_setup(led, &led_cfg); ret = max77693_setup(led, &led_cfg);
if (ret < 0) if (ret < 0)
return ret; goto err_setup;
mutex_init(&led->lock); mutex_init(&led->lock);
@ -1000,6 +1000,8 @@ static int max77693_led_probe(struct platform_device *pdev)
else else
goto err_register_led1; goto err_register_led1;
} }
of_node_put(sub_nodes[i]);
sub_nodes[i] = NULL;
} }
return 0; return 0;
@ -1013,6 +1015,9 @@ err_register_led2:
err_register_led1: err_register_led1:
mutex_destroy(&led->lock); mutex_destroy(&led->lock);
err_setup:
for (i = FLED1; i <= FLED2; i++)
of_node_put(sub_nodes[i]);
return ret; return ret;
} }