Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-10 07:10:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

media: ir_toy: fix a memleak in irtoy_tx

Browse Source 
When irtoy_command fails, buf should be freed since it is allocated by
irtoy_tx, or there is a memleak.

Fixes: 4114978dcd24 ("media: ir_toy: prevent device from hanging during transmit")
Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
Zhipeng Lu 2024-01-17 09:14:19 +01:00 committed by Mauro Carvalho Chehab
parent 6a9d552483
commit dc9ceb90c4
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/rc/ir_toy.c
View File

@ -332,6 +332,7 @@ static int irtoy_tx(struct rc_dev *rc, uint *txbuf, uint count)
sizeof(COMMAND_SMODE_EXIT), STATE_COMMAND_NO_RESP); sizeof(COMMAND_SMODE_EXIT), STATE_COMMAND_NO_RESP);
if (err) { if (err) {
dev_err(irtoy->dev, "exit sample mode: %d\n", err); dev_err(irtoy->dev, "exit sample mode: %d\n", err);
kfree(buf);
return err; return err;
} }
@ -339,6 +340,7 @@ static int irtoy_tx(struct rc_dev *rc, uint *txbuf, uint count)
sizeof(COMMAND_SMODE_ENTER), STATE_COMMAND); sizeof(COMMAND_SMODE_ENTER), STATE_COMMAND);
if (err) { if (err) {
dev_err(irtoy->dev, "enter sample mode: %d\n", err); dev_err(irtoy->dev, "enter sample mode: %d\n", err);
kfree(buf);
return err; return err;
} }