Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-20 04:19:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

block: mq-deadline: Clean up deadline_check_fifo()

Browse Source 
Change the return type of deadline_check_fifo() from 'int' into 'bool'.
Use time_is_before_eq_jiffies() instead of time_after_eq(). No
functionality has been changed.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20230517174230.897144-7-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Bart Van Assche 2023-05-17 10:42:24 -07:00 committed by Jens Axboe
parent 19821fee3e
commit e0d85cde95
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
block/mq-deadline.c
View File

@ -272,21 +272,15 @@ static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
} }
/* /*
* deadline_check_fifo returns 0 if there are no expired requests on the fifo, * deadline_check_fifo returns true if and only if there are expired requests
* 1 otherwise. Requires !list_empty(&dd->fifo_list[data_dir]) * in the FIFO list. Requires !list_empty(&dd->fifo_list[data_dir]).
*/ */
static inline int deadline_check_fifo(struct dd_per_prio *per_prio, static inline bool deadline_check_fifo(struct dd_per_prio *per_prio,
enum dd_data_dir data_dir) enum dd_data_dir data_dir)
{ {
struct request *rq = rq_entry_fifo(per_prio->fifo_list[data_dir].next); struct request *rq = rq_entry_fifo(per_prio->fifo_list[data_dir].next);
/* return time_is_before_eq_jiffies((unsigned long)rq->fifo_time);
* rq is expired!
*/
if (time_after_eq(jiffies, (unsigned long)rq->fifo_time))
return 1;
return 0;
} }
/* /*