Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-06 13:23:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mm/mempolicy.c: mpol_equal(): use bool

Browse Source 
mpol_equal() logically returns a boolean.  Use a bool type to slightly
improve readability.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Stephen Wilson <wilsons@start.ca>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
KOSAKI Motohiro 2012-01-10 15:08:21 -08:00 committed by Linus Torvalds
parent 0c176d52b0
commit fcfb4dcc96
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
include/linux/mempolicy.h
View File

@ -164,11 +164,11 @@ static inline void mpol_get(struct mempolicy *pol)
atomic_inc(&pol->refcnt); atomic_inc(&pol->refcnt);
} }
extern int __mpol_equal(struct mempolicy *a, struct mempolicy *b); extern bool __mpol_equal(struct mempolicy *a, struct mempolicy *b);
static inline int mpol_equal(struct mempolicy *a, struct mempolicy *b) static inline bool mpol_equal(struct mempolicy *a, struct mempolicy *b)
{ {
if (a == b) if (a == b)
return 1; return true;
return __mpol_equal(a, b); return __mpol_equal(a, b);
} }
@ -257,9 +257,9 @@ static inline int vma_migratable(struct vm_area_struct *vma)
struct mempolicy {}; struct mempolicy {};
static inline int mpol_equal(struct mempolicy *a, struct mempolicy *b) static inline bool mpol_equal(struct mempolicy *a, struct mempolicy *b)
{ {
return 1; return true;
} }
static inline void mpol_put(struct mempolicy *p) static inline void mpol_put(struct mempolicy *p)

14
mm/mempolicy.c
View File

@ -1983,28 +1983,28 @@ struct mempolicy *__mpol_cond_copy(struct mempolicy *tompol,
} }
/* Slow path of a mempolicy comparison */ /* Slow path of a mempolicy comparison */
int __mpol_equal(struct mempolicy *a, struct mempolicy *b) bool __mpol_equal(struct mempolicy *a, struct mempolicy *b)
{ {
if (!a || !b) if (!a || !b)
return 0; return false;
if (a->mode != b->mode) if (a->mode != b->mode)
return 0; return false;
if (a->flags != b->flags) if (a->flags != b->flags)
return 0; return false;
if (mpol_store_user_nodemask(a)) if (mpol_store_user_nodemask(a))
if (!nodes_equal(a->w.user_nodemask, b->w.user_nodemask)) if (!nodes_equal(a->w.user_nodemask, b->w.user_nodemask))
return 0; return false;
switch (a->mode) { switch (a->mode) {
case MPOL_BIND: case MPOL_BIND:
/* Fall through */ /* Fall through */
case MPOL_INTERLEAVE: case MPOL_INTERLEAVE:
return nodes_equal(a->v.nodes, b->v.nodes); return !!nodes_equal(a->v.nodes, b->v.nodes);
case MPOL_PREFERRED: case MPOL_PREFERRED:
return a->v.preferred_node == b->v.preferred_node; return a->v.preferred_node == b->v.preferred_node;
default: default:
BUG(); BUG();
return 0; return false;
} }
} }