Sachin Kamat
248c959152
staging: rtl8723au: Remove redundant casting in rtw_mlme_ext.c
...
Casting value returned by kzalloc is useless.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:09:48 -07:00
Alexey Tulia
a06a24d2b7
staging: usbip: fixed a coding-style warning
...
This fixes the following warning:
- WARNING: __constant_cpu_to_le32 should be cpu_to_le32
Signed-off-by: Alexey Tulia <alexey.tulia@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:08:58 -07:00
Geert Uytterhoeven
ee264346fa
staging: rtl8723au: Add compiler check for -Wtype-limits
...
Gcc versions before 4.3 do not support -Wtype-limits:
cc1: error: unrecognized command line option "-Wtype-limits"
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:08:58 -07:00
Jes Sorensen
7579a7e47d
staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Avoid pointless memcpy
...
There is no point copying a buffer, just to scan it and then free it
again.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:07:30 -07:00
Jes Sorensen
3798786626
staging: rtl8723au: Move FillH2CCmd() prototype to rtl8723a_cmd.h where it really belongs
...
As an added bonus, remove the now obsolete rtw_ioctl_set.h
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:07:30 -07:00
Jes Sorensen
da23732c63
staging: rtl8723au: Quiet unused variable warning when building with CONFIG_8723AU_AP_MODE=n
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:07:30 -07:00
Jes Sorensen
073c9d47c3
staging: rtl8723au: Don't run regular scans in the driver, the stack handles that
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:07:30 -07:00
Jes Sorensen
e9bb5ad46d
staging: rtl8723au: rtw_set_802_11_bssid23a_list_scan(): Use __func__ to print function name
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:07:30 -07:00
Jes Sorensen
27fd731ece
staging: rtl8723au: Move rtw_get_cur_max_rate23a() to ioctl_cfg80211.c
...
This function has only one caller, so move it home and declare it static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:07:08 -07:00
Jes Sorensen
023b40d882
staging: rtl8723au: rtw_get_cur_max_rate23a(): We are in N mode if WLAN_EID_HT_CAPABILITY is present
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:05:40 -07:00
Jes Sorensen
8f9558b906
staging: rtl8723au: rtw_get_cur_max_rate23a(): Remove duplicate fwstate checks
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:04:24 -07:00
Jes Sorensen
e007b4c77c
staging: rtl8723au: Move rtw_do_join23a() to rtw_mlme.c and declare it static
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:04:23 -07:00
Jes Sorensen
e89c05505f
staging: rtl8723au: rtw_do_join23a(): Don't start scanning if network isn't found
...
Don't start running network scans if trying to connect to a network
not in our cache. Let the 802.11 stack do it's job instead.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:04:23 -07:00
Jes Sorensen
72795e9de7
staging: rtl8723au: rtw_set_ssid(): Use rtw_do_join_network()
...
We already have the wlan_network we wish to join, hence it's pointless
to go back to the scanned_queue and pull it out of there, before
running the join logic.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:04:23 -07:00
Jes Sorensen
85b3c5e48e
staging: rtl8723au: rtw_select_and_join_from_scanned_queue23a() never returns 2
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:04:23 -07:00
Jes Sorensen
66ed1bc999
staging: rtl8723au: rtw_surveydone_event_callback23a(): We always set _FW_UNDER_LINKING
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:04:23 -07:00
Jes Sorensen
e5c4db0959
staging: rtl8723au: to_join will no be true if _FW_LINKED is set
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:04:23 -07:00
Jes Sorensen
3221bb536d
staging: rtl8723au: Remove no-op rtw_get_encrypt_decrypt_from_registrypriv23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:04:23 -07:00
Jes Sorensen
fcc6020ae8
staging: rtl8723au: Consolidate duplicate adhoc joining code into rtw_do_join_adhoc()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:04:23 -07:00
Jes Sorensen
ca3504be63
staging: rtl8723au: rtw_surveydone_event_callback23a(): Remove superfluous memset()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:03:49 -07:00
Jes Sorensen
557f9a452d
staging: rtl8723au: rtw_do_join23a(): Use __func__ to get function name in debug messages
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:03:49 -07:00
Jes Sorensen
b66dad2d50
staging: rtl8723au: Introduce rtw_do_join_network()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:03:49 -07:00
Jes Sorensen
0e634a029b
staging: rtl8723au: Introduce rtw_select_candidate_from_queue()
...
This splits a portion of rtw_select_and_join_from_scanned_queue23a()
into rtw_select_candidate_from_queue()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:03:49 -07:00
Jes Sorensen
fa862a7f79
staging: rtl8723au: Don't prepend debug console messages with 'ERROR '
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:03:49 -07:00
Jes Sorensen
2febc8679e
staging: rtl8723au: Minor debug message fixup
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:03:49 -07:00
Jes Sorensen
be82728e9c
staging: rtl8723au: rtw_do_join23a(): Use correct error return values
...
Don't mix true/fail with _SUCCESS/_FAIL as return value
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:03:49 -07:00
Jes Sorensen
4d9c63bbd2
staging: rtl8723au: rtw_cfg80211_add_wep(): Use WLAN_KEY_LEN_*
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:03:49 -07:00
Jes Sorensen
70fbc1a8a1
staging: rtl8723au: rtw_set_ssid(): This is never called with _FW_UNDER_LINKING
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:03:49 -07:00
Jes Sorensen
e73d82efa4
staging: rtl8723au: Pass a struct wlan_network to rtw_set_ssid()
...
There is no point copying the ssid out of struct wlan_network when we
can just pass on the whole struct.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:03:49 -07:00
Jes Sorensen
9cb08ff32c
staging: rtl8723au: cfg80211_rtw_connect(): Simplify ssid preparation
...
Since we just matched sme->{ssid,ssid_len} to
pnetwork->network.Ssid.{ssid,ssid_len} we can simplify the copy and
move it to just before the call to rtw_set_ssid().
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:20 -07:00
Jes Sorensen
9ab98d4240
staging: rtl8723au: cfg80211_rtw_connect(): Remove obfuscating pointers
...
dst_ssid and dst_bssid were just obfuscating that we were in fact
looking at pnetwork.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:20 -07:00
Jes Sorensen
c5178b0bc2
staging: rtl8723au: cfg80211_rtw_connect(): Clean up various bits
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:20 -07:00
Jes Sorensen
97c4361d50
staging: rtl8723au: Move rtw_set_802_11_ssid23a() to ioctl_cfg80211.c
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:20 -07:00
Jes Sorensen
39dbc446a7
staging: rtl8723au: Fold rtw_set_802_11_authentication_mode23a() into cfg80211_rtw_connect()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:20 -07:00
Jes Sorensen
7c0e063675
staging: rtl8723au: cfg80211_rtw_connect(): Check correct return value from rtw_set_802_11_ssid23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:20 -07:00
Jes Sorensen
ec36ce29ca
staging: rtl8723au: Make rtw_is_same_ibss23a() return bool
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:20 -07:00
Jes Sorensen
7b2e06a159
staging: rtl8723au: Get rid of IW_ESSID_MAX_SIZE
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:20 -07:00
Jes Sorensen
ded7a20f82
staging: rtl8723au: OnAuth23a(): Use ether_addr_copy()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:20 -07:00
Jes Sorensen
1ae17bf169
staging: rtl8723au: rtw_stadel_event_callback23a(): Remove superfluous memset()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:20 -07:00
Jes Sorensen
46805acb89
staging: rtl8723au: free_scanqueue(): Use _rtw_free_network23a()
...
Use _rtw_free_network23() so elements are freed in one place.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:20 -07:00
Jes Sorensen
8d7fb1b874
staging: rtl8723au: collect_bss_info(): Don't memset() what we just kzalloc()'d
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:20 -07:00
Jes Sorensen
1bebe75626
staging: rtl8723au: Allocate struct wlan_bssid_ex in collect_bss_info()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:19 -07:00
Jes Sorensen
246879640e
staging: rtl8723au: Do not embed struct wlan_bssid_ex in struct survey_event
...
Instead allocate it separately and reference it from survey_event.
This will allow for us to pass it on later without having to copy it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:19 -07:00
Jes Sorensen
7195dc0e1a
staging: rtl8723au: rtw_survey_event_cb23a(): Use the correct types for the received arguments
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 14:00:19 -07:00
Jes Sorensen
8ab7bdba0d
staging: rtl8723au: Declare rtw_update_scanned_network() static
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 13:51:54 -07:00
Jes Sorensen
bbf5fdbd56
staging: rtl8723au: rtw_check_bcn_info23a(): Don't search for WPA/WPA2 info twice
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 13:51:54 -07:00
Jes Sorensen
17b19396a6
staging: rtl8723au: rtw_check_bcn_info23a(): Don't make a local copy of beacon just to parse it
...
In addition be consistent with return values and parsing them.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 13:51:54 -07:00
Jes Sorensen
0c45e6170d
staging: rtl8723au: rtw_check_bcn_info23a(): Use ether_addr_equal() to check BSSID
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 13:51:53 -07:00
Jes Sorensen
51dacaa7ba
staging: rtl8723au: Remove some unused 80211 header parsing macros
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 13:51:53 -07:00
Jes Sorensen
e0ea5c8e66
staging: rtl8723au: Remove unused #defines WEP_KEY_LEN and MGMT_QUEUE_NUM
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 13:51:53 -07:00