Guenter Roeck
480cadc2b7
scsi: Fix qemu boot hang problem ...
The latest kernel fails to boot qemu arm images when using scsi
for disk access. Boot gets stuck after the following messages.
brd: module loaded
sym53c8xx 0000:00:0c.0: enabling device (0100 -> 0103)
sym0: <895a> rev 0x0 at pci 0000:00:0c.0 irq 93
sym0: No NVRAM, ID 7, Fast-40, LVD, parity checking
sym0: SCSI BUS has been reset.
scsi host0: sym-2.2.3
Bisect points to commit 71e75c97f97a ("scsi: convert device_busy to
atomic_t"). Code inspection shows the following suspicious change
in scsi_request_fn.
out_delay:
- if (sdev->device_busy == 0 && !scsi_device_blocked(sdev))
+ if (atomic_read(&sdev->device_busy) && !scsi_device_blocked(sdev))
blk_delay_queue(q, SCSI_QUEUE_DELAY);
}
'sdev->device_busy == 0' was replaced with 'atomic_read(&sdev->device_busy)',
meaning the logic was reversed. Changing this expression to
'!atomic_read(&sdev->device_busy)' fixes the problem.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Acked-by: Jens Axboe <axboe@fb.com>
Reviewed-by: Venkatesh Srinivas <venkateshs@google.com>
Reviewed-by: Webb Scales <webbnh@hp.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-08-19 12:42:26 -05:00
2014-07-17 22:07:37 +02:00
2014-07-25 17:16:54 -04:00
2014-07-17 22:07:37 +02:00
2014-07-17 22:07:37 +02:00
2014-08-12 12:15:14 -06:00
2014-07-29 08:38:52 -04:00
2014-07-25 17:16:59 -04:00
2014-07-25 17:17:06 -04:00
2014-08-12 12:15:14 -06:00
2014-08-13 20:04:47 -07:00
2014-06-06 07:57:37 -06:00
2014-05-19 19:12:23 +02:00
2014-05-07 13:15:46 +02:00
2014-07-29 08:38:23 -04:00
2014-07-25 17:16:55 -04:00
2014-08-12 12:15:14 -06:00
2014-07-25 07:43:43 -04:00
2014-07-29 08:38:53 -04:00
2014-08-08 15:57:29 -07:00
2014-07-25 17:17:03 -04:00
2014-08-12 12:15:14 -06:00
2014-08-06 21:03:53 -07:00
2014-06-06 07:57:37 -06:00
2014-07-17 22:07:37 +02:00
2014-08-15 18:28:58 -06:00
2014-07-25 17:16:55 -04:00
2014-08-01 08:16:39 -04:00
2014-07-17 22:07:37 +02:00
2014-08-12 12:15:14 -06:00
2013-11-29 08:48:39 +04:00
2014-08-08 15:57:29 -07:00
2013-11-29 08:48:39 +04:00
2014-07-25 17:16:56 -04:00
2014-07-17 22:07:37 +02:00
2014-08-08 15:57:29 -07:00
2013-11-26 11:09:07 +01:00
2013-11-26 11:09:07 +01:00
2013-11-26 11:09:07 +01:00
2014-07-25 07:43:43 -04:00
2014-07-17 22:07:37 +02:00
2014-07-17 22:07:37 +02:00
2014-06-09 18:54:06 -07:00
2014-05-28 12:11:08 +02:00
2013-10-14 15:26:04 +02:00
2014-08-12 12:15:14 -06:00
2014-07-17 22:07:40 +02:00
2014-07-17 22:07:38 +02:00
2014-07-17 22:07:37 +02:00
2014-07-17 22:07:37 +02:00
2014-05-28 12:10:43 +02:00
2014-03-19 15:04:44 -07:00
2014-08-08 15:57:29 -07:00
2014-07-17 22:07:37 +02:00
2014-05-28 12:05:37 +02:00
2014-03-19 15:04:44 -07:00
2013-11-26 11:09:07 +01:00
2014-07-25 17:16:28 -04:00
2014-06-02 09:55:02 +02:00
2014-08-08 15:57:29 -07:00
2014-06-02 09:54:59 +02:00
2014-07-17 22:07:37 +02:00
2014-07-17 22:07:37 +02:00
2014-03-19 15:04:44 -07:00
2014-04-01 19:19:15 -07:00
2014-03-19 15:04:42 -07:00
2013-11-29 08:48:39 +04:00
2014-03-15 10:19:19 -07:00
2014-05-23 16:28:53 -04:00
2014-04-11 16:15:36 -04:00
2014-07-25 17:16:55 -04:00
2014-03-15 10:19:18 -07:00
2014-08-01 08:16:39 -04:00
2014-05-28 12:10:43 +02:00
2014-05-28 12:05:37 +02:00
2014-07-17 22:07:44 +02:00
2014-07-17 22:07:38 +02:00
2014-03-27 08:26:31 -07:00
2014-08-08 15:57:29 -07:00
2014-08-12 12:15:14 -06:00
2014-07-17 22:07:37 +02:00
2014-07-17 22:07:35 +02:00
2014-07-25 17:16:56 -04:00
2014-07-17 22:07:37 +02:00
2014-05-28 18:14:16 +02:00
2014-07-17 22:07:37 +02:00
2014-06-06 07:57:37 -06:00
2014-07-25 17:16:55 -04:00
2014-05-28 12:05:36 +02:00
2014-08-08 15:57:28 -07:00
2014-07-17 22:07:37 +02:00
2014-02-27 08:07:39 -08:00
2014-07-25 17:16:55 -04:00
2014-07-25 07:43:43 -04:00
2014-07-26 11:55:35 -04:00
2014-07-29 18:01:10 -04:00
2014-07-25 07:43:43 -04:00
2014-07-17 22:07:41 +02:00
2014-08-19 12:42:26 -05:00
2014-04-24 13:44:54 -04:00
2014-04-10 15:30:35 -07:00
2014-07-25 17:16:28 -04:00
2014-07-17 22:07:37 +02:00
2014-07-29 18:01:10 -04:00
2014-06-06 16:08:16 -07:00
2014-08-08 15:57:28 -07:00
2014-07-01 07:13:39 -04:00
2014-07-25 17:16:54 -04:00
2014-08-04 13:16:14 +02:00
2014-07-17 22:07:37 +02:00
2014-08-14 11:09:05 -06:00
2014-07-29 08:28:04 -04:00
2013-11-23 22:33:50 -08:00
2014-07-25 17:16:42 -04:00
2014-07-17 22:07:33 +02:00
2014-03-27 08:26:31 -07:00
2014-07-25 07:43:45 -04:00
2014-07-17 22:07:39 +02:00
2014-07-17 22:07:39 +02:00
2014-07-25 17:16:41 -04:00
2014-07-25 17:16:41 -04:00
2014-07-17 22:07:41 +02:00
2013-10-14 15:26:04 +02:00
2014-07-25 17:23:25 -04:00
2014-07-17 22:07:37 +02:00
2014-05-28 12:16:28 +02:00
2014-05-28 12:16:28 +02:00
2014-05-28 12:11:33 +02:00
2014-05-28 12:05:37 +02:00
2014-05-28 12:05:37 +02:00
2014-07-17 22:07:37 +02:00
2013-10-25 11:51:37 +01:00
2014-08-01 08:18:37 -04:00
2014-07-25 17:17:00 -04:00
2014-07-29 08:38:53 -04:00
2014-03-19 15:04:46 -07:00
2014-07-17 22:07:37 +02:00
2014-03-19 15:04:44 -07:00
2013-11-26 11:09:07 +01:00
480cadc2b7