Paolo Abeni 4c0288299f mptcp: prevent tcp diag from closing listener subflows ... The MPTCP protocol does not expect that any other entity could change the first subflow status when such socket is listening. Unfortunately the TCP diag interface allows aborting any TCP socket, including MPTCP listeners subflows. As reported by syzbot, that trigger a WARN() and could lead to later bigger trouble. The MPTCP protocol needs to do some MPTCP-level cleanup actions to properly shutdown the listener. To keep the fix simple, prevent entirely the diag interface from stopping such listeners. We could refine the diag callback in a later, larger patch targeting net-next. Fixes: 57fc0f1cea ("mptcp: ensure listener is unhashed before updating the sk status") Cc: stable@vger.kernel.org Reported-by: <syzbot+5a01c3a666e726bc8752@syzkaller.appspotmail.com> Closes: https://lore.kernel.org/netdev/0000000000004f4579060c68431b@google.com/ Signed-off-by: Paolo Abeni <pabeni@redhat.com> Reviewed-by: Mat Martineau <martineau@kernel.org> Signed-off-by: Matthieu Baerts <matttbe@kernel.org> Link: https://lore.kernel.org/r/20231226-upstream-net-20231226-mptcp-prevent-warn-v1-2-1404dcc431ea@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-01-02 16:12:47 -08:00
..
6lowpan	6lowpan: Remove redundant initialisation.	2023-03-29 08:22:52 +01:00
9p	9p/net: fix possible memory leak in p9_check_errors()	2023-10-27 12:44:13 +09:00
802	net: fill in MODULE_DESCRIPTION()s under net/802*	2023-10-28 11:29:28 +01:00
8021q	net: check vlan filter feature in vlan_vids_add_by_dev() and vlan_vids_del_by_dev()	2023-12-19 13:13:56 +01:00
appletalk	appletalk: Fix Use-After-Free in atalk_ioctl	2023-12-14 12:02:45 +01:00
atm	atm: Fix Use-After-Free in do_vcc_ioctl	2023-12-12 13:14:08 +01:00
ax25	net: implement lockless SO_PRIORITY	2023-10-01 19:09:54 +01:00
batman-adv	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-08-24 10:51:39 -07:00
bluetooth	Bluetooth: af_bluetooth: Fix Use-After-Free in bt_sock_recvmsg	2023-12-15 11:54:18 -05:00
bpf	bpf: Add __bpf_kfunc_{start,end}_defs macros	2023-11-01 22:33:53 -07:00
bpfilter	net: Use umd_cleanup_helper()	2023-05-31 13:06:57 +02:00
bridge	netfilter: nf_conntrack_bridge: initialize err to 0	2023-11-14 16:16:21 +01:00
caif	sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)	2023-06-24 15:50:13 -07:00
can	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-10-12 17:07:34 -07:00
ceph	This update includes the following changes:	2023-11-02 16:15:30 -10:00
core	net: Implement missing getsockopt(SO_TIMESTAMPING_NEW)	2024-01-02 13:24:30 +00:00
dcb	net: dcb: choose correct policy to parse DCB_ATTR_BCN	2023-08-01 21:07:46 -07:00
dccp	dccp/tcp: Call security_inet_conn_request() after setting IPv6 addresses.	2023-11-02 12:56:03 +01:00
devlink	netlink: specs: devlink: add forgotten port function caps enum values	2023-11-01 22:13:43 -07:00
dns_resolver
dsa	net: dsa: Rename IFLA_DSA_MASTER to IFLA_DSA_CONDUIT	2023-10-24 13:08:14 -07:00
ethernet	net: ethernet: use sysfs_emit() to instead of scnprintf()	2022-12-07 20:02:44 -08:00
ethtool	ethtool: don't propagate EOPNOTSUPP from dumps	2023-11-29 08:43:27 -08:00
handshake	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-10-26 13:46:28 -07:00
hsr	hsr: Prevent use after free in prp_create_tagged_frame()	2023-11-01 22:26:04 -07:00
ieee802154	sysctl-6.6-rc1	2023-08-29 17:39:15 -07:00
ife	net: sched: ife: fix potential use-after-free	2023-12-15 10:50:18 +00:00
ipv4	net/tcp_sigpool: Use kref_get_unless_zero()	2024-01-01 14:42:05 +00:00
ipv6	Revert "net: ipv6/addrconf: clamp preferred_lft to the minimum required"	2024-01-02 14:58:46 -08:00
iucv	s390: use control register bit defines	2023-09-19 13:26:57 +02:00
kcm	net: kcm: fill in MODULE_DESCRIPTION()	2023-11-08 18:17:44 -08:00
key	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-08-18 12:44:56 -07:00
l2tp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-10-05 13:16:47 -07:00
l3mdev
lapb
llc	llc: verify mac len before reading mac header	2023-11-01 22:21:32 -07:00
mac80211	wifi: mac80211: add/remove driver debugfs entries as appropriate	2023-12-19 13:08:00 +01:00
mac802154	Core WPAN changes:	2023-06-24 15:41:46 -07:00
mctp	mctp: perform route lookups under a RCU read-side lock	2023-10-10 19:43:22 -07:00
mpls	networking: Update to register_net_sysctl_sz	2023-08-15 15:26:18 -07:00
mptcp	mptcp: prevent tcp diag from closing listener subflows	2024-01-02 16:12:47 -08:00
ncsi	Revert ncsi: Propagate carrier gain/loss events to the NCSI controller	2023-11-15 09:59:44 +00:00
netfilter	netfilter: nf_tables: skip set commit for deleted/destroyed sets	2023-12-20 13:48:00 +01:00
netlabel	netlabel: Remove unused declaration netlbl_cipsov4_doi_free()	2023-08-02 12:28:22 -07:00
netlink	drop_monitor: Require 'CAP_SYS_ADMIN' when joining "events" group	2023-12-07 09:54:02 -08:00
netrom	net: implement lockless SO_PRIORITY	2023-10-01 19:09:54 +01:00
nfc	nfc: Do not send datagram if socket state isn't LLCP_BOUND	2023-12-25 07:29:04 +00:00
nsh	net: move gso declarations and functions to their own files	2023-06-10 00:11:41 -07:00
openvswitch	net/sched: act_ct: Always fill offloading tuple iifidx	2023-11-08 17:47:08 -08:00
packet	packet: Move reference count in packet_sock to atomic_long_t	2023-12-04 14:45:04 -08:00
phonet	sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)	2023-06-24 15:50:13 -07:00
psample	psample: Require 'CAP_NET_ADMIN' when joining "packets" group	2023-12-07 09:54:02 -08:00
qrtr	net: qrtr: ns: Return 0 if server port is not present	2024-01-01 18:41:29 +00:00
rds	net: prevent address rewrite in kernel_bind()	2023-10-01 19:31:29 +01:00
rfkill	net: rfkill: gpio: set GPIO direction	2023-12-12 10:14:57 +01:00
rose	net/rose: fix races in rose_kill_by_device()	2023-12-15 11:59:53 +00:00
rxrpc	rxrpc: Defer the response to a PING ACK until we've parsed it	2023-11-17 02:50:33 +00:00
sched	net: sched: em_text: fix possible memory leak in em_text_destroy()	2024-01-01 13:08:15 +00:00
sctp	net: fill in MODULE_DESCRIPTION()s for SOCK_DIAG modules	2023-11-19 20:09:13 +00:00
smc	net/smc: fix missing byte order conversion in CLC handshake	2023-12-07 10:10:56 -08:00
strparser
sunrpc	nfsd-6.7 fixes:	2023-12-20 11:16:50 -08:00
switchdev	net: switchdev: Add a helper to replay objects on a bridge port	2023-07-21 08:54:03 +01:00
tipc	net: fill in MODULE_DESCRIPTION()s for SOCK_DIAG modules	2023-11-19 20:09:13 +00:00
tls	net: tls, update curr on splice as well	2023-12-07 09:52:28 -08:00
unix	bpf, sockmap: af_unix stream sockets need to hold ref for pair sock	2023-11-30 00:25:16 +01:00
vmw_vsock	vsock/virtio: Fix unsigned integer wrap around in virtio_transport_has_space()	2023-12-13 17:59:08 -08:00
wireless	wifi: cfg80211: fix certs build to not depend on file order	2023-12-14 09:11:51 +01:00
x25	net: implement lockless SO_PRIORITY	2023-10-01 19:09:54 +01:00
xdp	xsk: Skip polling event check for unbound socket	2023-12-05 13:43:43 +01:00
xfrm	Including fixes from netfilter and bpf.	2023-11-09 17:09:35 -08:00
compat.c	net/compat: Update msg_control_is_user when setting a kernel pointer	2023-04-14 11:09:27 +01:00
devres.c
Kconfig	net: add skb_segment kunit test	2023-10-11 10:39:01 +01:00
Kconfig.debug
Makefile	net/handshake: Create a NETLINK service for handling handshake requests	2023-04-19 18:48:48 -07:00
socket.c	bpf: Add __bpf_hook_{start,end} macros	2023-11-01 22:33:53 -07:00
sysctl_net.c	sysctl: Add size to register_net_sysctl function	2023-08-15 15:26:17 -07:00