Pavel Begunkov 4d9cb92ca4 io_uring/rw: fix short rw error handling ... We have a couple of problems, first reports of unexpected link breakage for reads when cqe->res indicates that the IO was done in full. The reason here is partial IO with retries. TL;DR; we compare the result in __io_complete_rw_common() against req->cqe.res, but req->cqe.res doesn't store the full length but rather the length left to be done. So, when we pass the full corrected result via kiocb_done() -> __io_complete_rw_common(), it fails. The second problem is that we don't try to correct res in io_complete_rw(), which, for instance, might be a problem for O_DIRECT but when a prefix of data was cached in the page cache. We also definitely don't want to pass a corrected result into io_rw_done(). The fix here is to leave __io_complete_rw_common() alone, always pass not corrected result into it and fix it up as the last step just before actually finishing the I/O. Cc: stable@vger.kernel.org Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> Link: https://github.com/axboe/liburing/issues/643 Reported-by: Beld Zhang <beldzhang@gmail.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2022-09-09 08:57:57 -06:00
..
advise.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
advise.h	io_uring: split out fadvise/madvise operations	2022-07-24 18:39:11 -06:00
alloc_cache.h	io_uring: impose max limit on apoll cache	2022-07-24 18:39:17 -06:00
cancel.c	io_uring: fix off-by-one in sync cancelation file check	2022-08-23 07:26:08 -06:00
cancel.h	io_uring: add sync cancelation API through io_uring_register()	2022-07-24 18:39:15 -06:00
epoll.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
epoll.h	io_uring: move epoll handler to its own file	2022-07-24 18:39:11 -06:00
fdinfo.c	io_uring: move a few private types to local headers	2022-07-24 18:39:14 -06:00
fdinfo.h	io_uring: move fdinfo helpers to its own file	2022-07-24 18:39:12 -06:00
filetable.c	io_uring: let to set a range for file slot allocation	2022-07-24 18:39:16 -06:00
filetable.h	io_uring: let to set a range for file slot allocation	2022-07-24 18:39:16 -06:00
fs.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
fs.h	io_uring: split out filesystem related operations	2022-07-24 18:39:11 -06:00
io_uring.c	io_uring: recycle kbuf recycle on tw requeue	2022-09-07 10:36:10 -06:00
io_uring.h	io_uring: export req alloc from core	2022-07-27 08:50:50 -06:00
io-wq.c	audit, io_uring, io-wq: Fix memory leak in io_sq_thread() and io_wqe_worker()	2022-08-04 08:33:54 -06:00
io-wq.h	io_uring: move list helpers to a separate file	2022-07-24 18:39:15 -06:00
kbuf.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
kbuf.h	io_uring/kbuf: fix not advancing READV kbuf ring	2022-09-07 10:36:10 -06:00
Makefile	io_uring: add zc notification infrastructure	2022-07-24 18:41:06 -06:00
msg_ring.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
msg_ring.h	io_uring: move msg_ring into its own file	2022-07-24 18:39:12 -06:00
net.c	io_uring/net: copy addr for zc on POLL_FIRST	2022-09-08 08:28:38 -06:00
net.h	io_uring/net: simplify zerocopy send user API	2022-09-01 09:13:33 -06:00
nop.c	io_uring: kill extra io_uring_types.h includes	2022-07-24 18:39:14 -06:00
nop.h	io_uring: move nop into its own file	2022-07-24 18:39:11 -06:00
notif.c	io_uring/notif: Remove the unused function io_notif_complete()	2022-09-05 11:42:39 -06:00
notif.h	io_uring/net: simplify zerocopy send user API	2022-09-01 09:13:33 -06:00
opdef.c	io_uring/net: simplify zerocopy send user API	2022-09-01 09:13:33 -06:00
opdef.h	io_uring: conditional ->async_data allocation	2022-08-24 08:57:28 -06:00
openclose.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
openclose.h	io_uring: split out fixed file installation and removal	2022-07-24 18:39:16 -06:00
poll.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
poll.h	io_uring: add abstraction around apoll cache	2022-07-24 18:39:17 -06:00
refs.h	io_uring: make io_uring_types.h public	2022-07-24 18:39:14 -06:00
rsrc.c	Revert "io_uring: rename IORING_OP_FILES_UPDATE"	2022-09-01 09:13:33 -06:00
rsrc.h	Revert "io_uring: rename IORING_OP_FILES_UPDATE"	2022-09-01 09:13:33 -06:00
rw.c	io_uring/rw: fix short rw error handling	2022-09-09 08:57:57 -06:00
rw.h	io_uring: move read/write related opcodes to its own file	2022-07-24 18:39:12 -06:00
slist.h	io_uring: move list helpers to a separate file	2022-07-24 18:39:15 -06:00
splice.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
splice.h	io_uring: split out splice related operations	2022-07-24 18:39:11 -06:00
sqpoll.c	audit, io_uring, io-wq: Fix memory leak in io_sq_thread() and io_wqe_worker()	2022-08-04 08:33:54 -06:00
sqpoll.h	io_uring: move SQPOLL related handling into its own file	2022-07-24 18:39:12 -06:00
statx.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
statx.h	io_uring: move statx handling to its own file	2022-07-24 18:39:11 -06:00
sync.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
sync.h	io_uring: split out fs related sync/fallocate functions	2022-07-24 18:39:11 -06:00
tctx.c	io_uring: lockless task list	2022-07-24 18:39:15 -06:00
tctx.h	io_uring: export io_put_task()	2022-07-24 18:41:06 -06:00
timeout.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
timeout.h	io_uring: move a few private types to local headers	2022-07-24 18:39:14 -06:00
uring_cmd.c	io_uring: fix submission-failure handling for uring-cmd	2022-08-23 09:46:17 -06:00
uring_cmd.h	io_uring: move uring_cmd handling to its own file	2022-07-24 18:39:11 -06:00
xattr.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
xattr.h	io_uring: move xattr related opcodes to its own file	2022-07-24 18:39:11 -06:00