linux/fs/f2fs
Chao Yu 5cdb422c83 f2fs: fix to avoid use-after-free for cached IPU bio
xfstest generic/019 reports a bug:

kernel BUG at mm/filemap.c:1619!
RIP: 0010:folio_end_writeback+0x8a/0x90
Call Trace:
 end_page_writeback+0x1c/0x60
 f2fs_write_end_io+0x199/0x420
 bio_endio+0x104/0x180
 submit_bio_noacct+0xa5/0x510
 submit_bio+0x48/0x80
 f2fs_submit_write_bio+0x35/0x300
 f2fs_submit_merged_ipu_write+0x2a0/0x2b0
 f2fs_write_single_data_page+0x838/0x8b0
 f2fs_write_cache_pages+0x379/0xa30
 f2fs_write_data_pages+0x30c/0x340
 do_writepages+0xd8/0x1b0
 __writeback_single_inode+0x44/0x370
 writeback_sb_inodes+0x233/0x4d0
 __writeback_inodes_wb+0x56/0xf0
 wb_writeback+0x1dd/0x2d0
 wb_workfn+0x367/0x4a0
 process_one_work+0x21d/0x430
 worker_thread+0x4e/0x3c0
 kthread+0x103/0x130
 ret_from_fork+0x2c/0x50

The root cause is: after cp_error is set, f2fs_submit_merged_ipu_write()
in f2fs_write_single_data_page() tries to flush IPU bio in cache, however
f2fs_submit_merged_ipu_write() missed to check validity of @bio parameter,
result in submitting random cached bio which belong to other IO context,
then it will cause use-after-free issue, fix it by adding additional
validity check.

Fixes: 0b20fcec86 ("f2fs: cache global IPU bio")
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
2023-04-10 11:01:49 -07:00
..
acl.c fs: port i_{g,u}id_into_vfs{g,u}id() to mnt_idmap 2023-01-19 09:24:29 +01:00
acl.h fs: port ->set_acl() to pass mnt_idmap 2023-01-19 09:24:27 +01:00
checkpoint.c f2fs: use f2fs_hw_is_readonly() instead of bdev_read_only() 2023-04-10 11:00:31 -07:00
compress.c f2fs: merge lz4hc_compress_pages() to lz4_compress_pages() 2023-04-10 10:58:45 -07:00
data.c f2fs: fix to avoid use-after-free for cached IPU bio 2023-04-10 11:01:49 -07:00
debug.c f2fs: convert to MAX_SBI_FLAG instead of 32 in stat_show() 2023-03-29 15:17:39 -07:00
dir.c f2fs: use common implementation of file type 2023-04-10 10:58:45 -07:00
extent_cache.c f2fs: remove entire rb_entry sharing 2023-03-29 15:17:38 -07:00
f2fs.h f2fs: remove unneeded in-memory i_crtime copy 2023-04-10 11:00:58 -07:00
file.c f2fs: preserve direct write semantics when buffering is forced 2023-03-29 15:17:39 -07:00
gc.c f2fs: Fix system crash due to lack of free space in LFS 2023-04-10 10:58:45 -07:00
gc.h f2fs: Fix system crash due to lack of free space in LFS 2023-04-10 10:58:45 -07:00
hash.c f2fs: don't use casefolded comparison for "." and ".." 2022-05-17 11:19:23 -07:00
inline.c f2fs: use common implementation of file type 2023-04-10 10:58:45 -07:00
inode.c f2fs: remove unneeded in-memory i_crtime copy 2023-04-10 11:00:58 -07:00
iostat.c f2fs: use iostat_lat_type directly as a parameter in the iostat_update_and_unbind_ctx() 2023-02-07 10:39:28 -08:00
iostat.h f2fs: use iostat_lat_type directly as a parameter in the iostat_update_and_unbind_ctx() 2023-02-07 10:39:28 -08:00
Kconfig f2fs: introduce F2FS_UNFAIR_RWSEM to support unfair rwsem 2022-03-04 09:15:53 -08:00
Makefile f2fs: separate out iostat feature 2021-08-23 10:25:51 -07:00
namei.c f2fs: convert is_extension_exist() to return bool type 2023-04-04 13:57:29 -07:00
node.c f2fs-for-6.3-rc1 2023-02-27 16:18:51 -08:00
node.h f2fs: convert to use bitmap API 2023-03-29 15:17:37 -07:00
recovery.c fs: port i_{g,u}id_into_vfs{g,u}id() to mnt_idmap 2023-01-19 09:24:29 +01:00
segment.c f2fs: remove struct victim_selection default_v_ops 2023-04-10 10:58:44 -07:00
segment.h f2fs: Fix system crash due to lack of free space in LFS 2023-04-10 10:58:45 -07:00
shrinker.c f2fs: add block_age-based extent cache 2022-12-12 14:53:56 -08:00
super.c f2fs: use f2fs_hw_is_readonly() instead of bdev_read_only() 2023-04-10 11:00:31 -07:00
sysfs.c f2fs: convert to use sysfs_emit 2023-04-10 10:58:45 -07:00
verity.c f2fs-for-6.3-rc1 2023-02-27 16:18:51 -08:00
xattr.c fs: port inode_owner_or_capable() to mnt_idmap 2023-01-19 09:24:29 +01:00
xattr.h f2fs: code cleanup by removing ifdef macro surrounding 2020-05-26 18:56:10 -07:00