Yang Yingliang
5d7bebf2df
scsi: scsi_transport_sas: Fix error handling in sas_phy_add() ...
If transport_add_device() fails in sas_phy_add(), the kernel will crash
trying to delete the device in transport_remove_device() called from
sas_remove_host().
Unable to handle kernel NULL pointer dereference at virtual address 0000000000000108
CPU: 61 PID: 42829 Comm: rmmod Kdump: loaded Tainted: G W 6.1.0-rc1+ #173
pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : device_del+0x54/0x3d0
lr : device_del+0x37c/0x3d0
Call trace:
device_del+0x54/0x3d0
attribute_container_class_device_del+0x28/0x38
transport_remove_classdev+0x6c/0x80
attribute_container_device_trigger+0x108/0x110
transport_remove_device+0x28/0x38
sas_phy_delete+0x30/0x60 [scsi_transport_sas]
do_sas_phy_delete+0x6c/0x80 [scsi_transport_sas]
device_for_each_child+0x68/0xb0
sas_remove_children+0x40/0x50 [scsi_transport_sas]
sas_remove_host+0x20/0x38 [scsi_transport_sas]
hisi_sas_remove+0x40/0x68 [hisi_sas_main]
hisi_sas_v2_remove+0x20/0x30 [hisi_sas_v2_hw]
platform_remove+0x2c/0x60
Fix this by checking and handling return value of transport_add_device()
in sas_phy_add().
Fixes: c7ebbbce366c ("[SCSI] SAS transport class")
Suggested-by: John Garry <john.g.garry@oracle.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221107124828.115557-1-yangyingliang@huawei.com
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2022-11-08 01:52:52 +00:00
2022-08-04 19:47:37 -07:00
2022-09-15 22:01:24 -04:00
2022-06-10 13:08:06 -04:00
2021-10-16 21:45:54 -04:00
2022-02-22 21:11:03 -05:00
2022-06-21 21:19:23 -04:00
2022-04-25 23:38:38 -04:00
2022-05-16 21:26:50 -04:00
2022-06-21 21:14:54 -04:00
2022-09-15 22:35:21 -04:00
2022-10-11 17:42:58 -06:00
2022-09-06 22:05:59 -04:00
2022-07-14 12:14:32 -06:00
2022-05-19 20:16:27 -04:00
2022-09-06 22:24:37 -04:00
2022-10-11 17:42:55 -06:00
2022-08-04 19:47:37 -07:00
2022-10-07 12:33:18 -07:00
2022-11-07 18:57:39 +00:00
2022-09-15 22:30:26 -04:00
2022-05-23 23:24:10 -04:00
2022-05-16 21:26:50 -04:00
2022-10-07 12:33:18 -07:00
2022-10-21 01:10:34 +00:00
2022-10-21 01:10:34 +00:00
2022-10-22 03:14:51 +00:00
2022-10-07 12:33:18 -07:00
2022-04-06 22:27:08 -04:00
2022-04-06 22:11:52 -04:00
2022-10-22 03:05:52 +00:00
2022-10-07 12:33:18 -07:00
2022-10-11 17:42:55 -06:00
2022-10-21 01:10:34 +00:00
2022-04-25 23:33:36 -04:00
2022-08-22 10:07:53 -06:00
2022-08-04 19:47:37 -07:00
2022-06-21 21:41:19 -04:00
2022-09-06 22:22:24 -04:00
2021-05-15 18:01:34 -04:00
2022-01-24 23:30:28 -05:00
2021-01-22 21:14:08 -05:00
2022-09-25 13:06:00 -04:00
2022-09-25 13:06:00 -04:00
2022-02-22 21:11:03 -05:00
2021-05-07 00:26:34 -07:00
2021-11-29 23:02:13 -05:00
2022-07-07 17:01:22 -04:00
2022-07-07 17:01:22 -04:00
2022-02-22 21:11:03 -05:00
2022-03-29 23:42:18 -04:00
2022-04-25 23:25:11 -04:00
2021-01-13 00:14:07 -05:00
2022-02-22 21:11:02 -05:00
2022-02-22 21:11:03 -05:00
2021-11-29 23:02:13 -05:00
2021-01-22 21:14:08 -05:00
2022-06-27 22:52:05 -04:00
2021-05-14 22:19:04 -04:00
2022-07-26 22:13:29 -04:00
2021-06-02 23:09:39 -04:00
2022-04-26 08:51:56 -04:00
2021-01-22 21:14:10 -05:00
2022-02-22 21:11:03 -05:00
2022-02-22 21:11:04 -05:00
2022-02-22 21:11:04 -05:00
2021-01-26 07:42:27 +01:00
2022-02-22 21:11:04 -05:00
2022-08-01 19:52:03 -04:00
2022-02-22 21:11:03 -05:00
2022-07-13 23:18:26 -04:00
2022-09-01 01:02:10 -04:00
2021-04-01 22:52:40 -04:00
2022-09-01 00:45:12 -04:00
2022-09-25 13:02:23 -04:00
2022-09-25 13:04:17 -04:00
2022-02-22 21:11:04 -05:00
2022-02-22 21:11:04 -05:00
2022-08-31 23:39:57 -04:00
2022-02-22 21:11:05 -05:00
2022-06-07 22:05:14 -04:00
2021-06-29 16:46:08 -04:00
2022-02-22 21:11:02 -05:00
2021-05-07 00:26:34 -07:00
2022-09-25 14:27:47 -04:00
2022-09-25 14:27:47 -04:00
2021-04-13 00:20:48 -04:00
2022-09-25 12:46:59 -04:00
2021-08-30 10:18:25 +02:00
2022-06-21 21:19:23 -04:00
2022-06-21 21:19:23 -04:00
2022-04-25 23:23:05 -04:00
2022-02-27 21:35:30 -05:00
2022-02-22 21:11:03 -05:00
2022-06-27 22:56:21 -04:00
2022-04-26 09:02:44 -04:00
2022-02-22 21:11:05 -05:00
2022-06-26 10:29:44 +10:00
2022-02-27 21:34:02 -05:00
2022-02-22 21:11:07 -05:00
2022-02-22 21:11:06 -05:00
2022-02-22 21:11:06 -05:00
2022-05-23 23:24:10 -04:00
2022-01-25 00:09:41 -05:00
2022-02-22 21:11:07 -05:00
2022-02-22 21:11:07 -05:00
2022-02-22 21:11:03 -05:00
2022-02-22 21:11:03 -05:00
2022-02-22 21:11:06 -05:00
2022-02-22 21:11:06 -05:00
2022-06-07 22:05:14 -04:00
2022-03-29 23:32:26 -04:00
2022-02-22 21:11:06 -05:00
2021-10-16 21:32:16 -04:00
2022-05-19 20:26:21 -04:00
2022-02-22 21:11:06 -05:00
2022-02-22 21:11:02 -05:00
2022-02-22 21:11:02 -05:00
2022-09-06 22:14:14 -04:00
2022-03-15 14:05:02 -04:00
2021-07-28 22:24:27 -04:00
2022-08-22 10:07:53 -06:00
2022-03-01 22:21:50 -05:00
2021-07-21 23:49:02 -04:00
2021-03-24 23:03:43 -04:00
2022-10-07 12:33:18 -07:00
2022-09-30 07:51:13 -06:00
2022-10-07 12:33:18 -07:00
2022-03-29 23:29:19 -04:00
2021-12-22 23:38:29 -05:00
2022-10-07 12:33:18 -07:00
2022-01-22 08:33:37 +02:00
2022-09-01 01:02:10 -04:00
2022-10-18 02:26:29 +00:00
2022-09-25 12:52:48 -04:00
2022-07-07 17:20:43 -04:00
2022-11-08 01:52:52 +00:00
2022-09-07 21:53:48 +02:00
2021-04-05 23:14:53 -04:00
2022-09-01 01:02:10 -04:00
2022-05-08 14:28:18 -04:00
2022-05-02 16:59:11 -04:00
2022-07-14 12:14:30 -06:00
2022-08-22 22:45:25 -04:00
2022-08-22 22:45:25 -04:00
2021-09-28 22:42:06 -04:00
2022-09-30 07:51:13 -06:00
2022-02-22 21:11:07 -05:00
2021-03-18 22:52:29 -04:00
2021-05-07 00:26:34 -07:00
2022-04-18 22:48:31 -04:00
2021-12-22 23:41:13 -05:00
2022-06-28 06:30:26 -06:00
2022-03-08 19:40:01 -07:00
2022-10-07 12:33:18 -07:00
2022-03-08 19:40:00 -07:00
2022-09-25 14:15:03 -04:00
2022-10-10 13:59:01 -07:00
2022-02-22 21:11:03 -05:00
2021-04-13 00:20:48 -04:00
2022-10-07 12:33:18 -07:00
2022-04-06 23:01:54 -04:00
2022-06-07 21:30:56 -04:00
2022-09-25 13:29:53 -04:00
2022-09-25 13:29:53 -04:00
2022-03-01 23:56:28 -05:00
2022-02-22 21:11:07 -05:00
2022-09-06 22:05:58 -04:00
2022-02-22 21:11:07 -05:00
2022-03-30 00:05:42 -04:00
5d7bebf2df