mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-01-11 15:49:56 +00:00
47d8e00ca3
The newly added debug mode for the synaptics-rmi4 driver relies on
the v4l2 interface and vb2_vmalloc, but those might be configured
as loadable modules when the driver itself is built-in, resulting
in a link failure:
drivers/input/rmi4/rmi_core.o: In function `rmi_f54_remove':
rmi_f54.c:(.text.rmi_f54_remove+0x14): undefined reference to `video_unregister_device'
rmi_f54.c:(.text.rmi_f54_remove+0x20): undefined reference to `v4l2_device_unregister'
drivers/input/rmi4/rmi_core.o: In function `rmi_f54_vidioc_s_input':
rmi_f54.c:(.text.rmi_f54_vidioc_s_input+0x10): undefined reference to `video_devdata'
drivers/input/rmi4/rmi_core.o: In function `rmi_f54_vidioc_g_input':
rmi_f54.c:(.text.rmi_f54_vidioc_g_input+0x10): undefined reference to `video_devdata'
drivers/input/rmi4/rmi_core.o: In function `rmi_f54_vidioc_fmt':
rmi_f54.c:(.text.rmi_f54_vidioc_fmt+0x10): undefined reference to `video_devdata'
drivers/input/rmi4/rmi_core.o: In function `rmi_f54_vidioc_enum_input':
rmi_f54.c:(.text.rmi_f54_vidioc_enum_input+0x10): undefined reference to `video_devdata'
drivers/input/rmi4/rmi_core.o: In function `rmi_f54_vidioc_querycap':
...
The best workaround I could come up with is to disallow the debug
mode unless it's actually possible to call it.
Fixes: 3a762dbd5347 ("[media] Input: synaptics-rmi4 - add support for F54 diagnostics")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Nick Dyer <nick@shmanahar.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
75 lines
1.9 KiB
Plaintext
75 lines
1.9 KiB
Plaintext
#
|
|
# RMI4 configuration
|
|
#
|
|
config RMI4_CORE
|
|
tristate "Synaptics RMI4 bus support"
|
|
help
|
|
Say Y here if you want to support the Synaptics RMI4 bus. This is
|
|
required for all RMI4 device support.
|
|
|
|
If unsure, say Y.
|
|
|
|
config RMI4_I2C
|
|
tristate "RMI4 I2C Support"
|
|
depends on RMI4_CORE && I2C
|
|
help
|
|
Say Y here if you want to support RMI4 devices connected to an I2C
|
|
bus.
|
|
|
|
If unsure, say Y.
|
|
|
|
config RMI4_SPI
|
|
tristate "RMI4 SPI Support"
|
|
depends on RMI4_CORE && SPI
|
|
help
|
|
Say Y here if you want to support RMI4 devices connected to a SPI
|
|
bus.
|
|
|
|
If unsure, say N.
|
|
|
|
config RMI4_2D_SENSOR
|
|
bool
|
|
depends on RMI4_CORE
|
|
|
|
config RMI4_F11
|
|
bool "RMI4 Function 11 (2D pointing)"
|
|
select RMI4_2D_SENSOR
|
|
depends on RMI4_CORE
|
|
help
|
|
Say Y here if you want to add support for RMI4 function 11.
|
|
|
|
Function 11 provides 2D multifinger pointing for touchscreens and
|
|
touchpads. For sensors that support relative pointing, F11 also
|
|
provides mouse input.
|
|
|
|
config RMI4_F12
|
|
bool "RMI4 Function 12 (2D pointing)"
|
|
select RMI4_2D_SENSOR
|
|
depends on RMI4_CORE
|
|
help
|
|
Say Y here if you want to add support for RMI4 function 12.
|
|
|
|
Function 12 provides 2D multifinger pointing for touchscreens and
|
|
touchpads. For sensors that support relative pointing, F12 also
|
|
provides mouse input.
|
|
|
|
config RMI4_F30
|
|
bool "RMI4 Function 30 (GPIO LED)"
|
|
depends on RMI4_CORE
|
|
help
|
|
Say Y here if you want to add support for RMI4 function 30.
|
|
|
|
Function 30 provides GPIO and LED support for RMI4 devices. This
|
|
includes support for buttons on TouchPads and ClickPads.
|
|
|
|
config RMI4_F54
|
|
bool "RMI4 Function 54 (Analog diagnostics)"
|
|
depends on RMI4_CORE
|
|
depends on VIDEO_V4L2=y || (RMI4_CORE=m && VIDEO_V4L2=m)
|
|
select VIDEOBUF2_VMALLOC
|
|
help
|
|
Say Y here if you want to add support for RMI4 function 54
|
|
|
|
Function 54 provides access to various diagnostic features in certain
|
|
RMI4 touch sensors.
|