linux/include/asm-powerpc
Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:

	u64 val = PAGE_ALIGN(size);

always returns a value < 4GB even if size is greater than 4GB.

The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):

#define PAGE_SHIFT      12
#define PAGE_SIZE       (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK       (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr)       (((addr)+PAGE_SIZE-1)&PAGE_MASK)

The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.

Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.

See also lkml discussion: http://lkml.org/lkml/2008/6/11/237

[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
2008-01-30 13:34:07 +01:00
2006-01-09 14:49:54 +11:00
2007-07-31 21:12:07 -07:00
2005-09-28 15:42:53 +10:00
2008-02-03 16:32:51 +02:00
2008-02-06 10:41:00 -08:00
2006-12-04 20:39:30 +11:00
2008-05-29 07:06:56 -05:00
2008-05-29 07:06:56 -05:00
2008-05-29 07:06:56 -05:00
2008-05-29 07:06:56 -05:00
2008-02-06 10:41:02 -08:00
2007-03-09 15:03:25 +11:00
2007-03-22 22:52:55 +11:00
2007-07-17 10:23:11 -07:00
2007-10-17 08:42:55 -07:00
2007-10-11 09:14:31 -05:00
2008-04-18 00:46:35 +02:00
2008-07-24 10:47:15 -07:00
2008-07-15 12:24:53 +10:00
2008-06-06 21:22:09 +03:00
2008-04-27 18:21:39 +03:00
2007-05-08 11:15:20 -07:00
2007-06-28 19:16:38 +10:00
2008-07-15 12:24:53 +10:00
2007-10-19 11:53:41 -07:00
2008-04-27 18:21:37 +03:00
2007-08-20 07:28:48 -05:00
2006-12-11 16:35:07 +11:00
2008-05-23 16:53:23 +10:00
2007-05-08 11:15:05 -07:00
2008-03-05 16:34:39 -06:00
2008-07-24 10:47:15 -07:00
2008-07-24 10:47:15 -07:00
2008-07-24 10:47:15 -07:00
2006-06-30 18:20:44 +02:00
2007-04-24 21:31:51 +10:00
2007-05-11 08:29:34 -07:00
2007-06-28 19:19:20 +10:00
2008-04-17 10:42:34 -04:00
2008-07-16 11:07:59 +10:00
2005-11-03 16:02:23 +11:00
2007-05-02 20:04:30 +10:00
2008-07-03 16:58:10 +10:00
2007-05-08 11:54:20 +10:00
2005-11-03 16:59:17 +11:00
2008-02-07 08:42:30 -08:00