Brian Foster
9bdd9bd69b
xfs: buffer ->bi_end_io function requires irq-safe lock ...
Reports have surfaced of a lockdep splat complaining about an
irq-safe -> irq-unsafe locking order in the xfs_buf_bio_end_io() bio
completion handler. This only occurs when I/O errors are present
because bp->b_lock is only acquired in this context to protect
setting an error on the buffer. The problem is that this lock can be
acquired with the (request_queue) q->queue_lock held. See
scsi_end_request() or ata_qc_schedule_eh(), for example.
Replace the locked test/set of b_io_error with a cmpxchg() call.
This eliminates the need for the lock and thus the lock ordering
problem goes away.
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2016-05-18 10:56:41 +10:00
2016-03-15 11:44:35 +11:00
2014-07-30 09:12:05 +10:00
2015-10-12 16:04:45 +11:00
2016-01-14 16:00:49 -08:00
2016-03-18 11:42:53 -04:00
2013-05-07 18:45:36 -05:00
2011-08-12 16:21:35 -05:00
2012-11-19 20:11:24 -06:00
2015-12-06 21:34:16 -05:00
2015-12-06 21:34:16 -05:00
2016-03-21 11:53:05 -07:00
2016-03-21 11:53:05 -07:00
2015-06-23 08:49:01 +10:00
2016-03-02 09:51:09 +11:00
2013-08-12 16:53:39 -05:00
2016-03-21 11:53:05 -07:00
2015-03-25 15:08:56 +11:00
2016-02-10 15:01:11 +11:00
2015-08-25 10:05:13 +10:00
2016-05-18 10:56:41 +10:00
2016-02-10 15:01:30 +11:00
2016-02-09 16:54:58 +11:00
2016-03-02 09:57:04 +11:00
2011-08-12 16:21:35 -05:00
2014-11-28 14:27:09 +11:00
2013-12-13 11:34:08 +11:00
2016-02-08 11:27:55 +11:00
2015-01-09 10:48:58 +11:00
2016-01-04 16:10:19 +11:00
2015-06-22 09:44:02 +10:00
2016-03-24 19:50:32 -07:00
2011-08-12 16:21:35 -05:00
2014-11-28 14:25:04 +11:00
2013-10-23 16:28:49 -05:00
2015-08-19 10:01:08 +10:00
2015-08-19 09:51:16 +10:00
2016-03-07 09:30:32 +11:00
2016-02-09 16:54:58 +11:00
2014-04-23 07:11:52 +10:00
2015-08-19 10:31:41 +10:00
2016-02-08 14:58:07 +11:00
2014-09-09 11:56:13 +10:00
2016-02-09 16:54:58 +11:00
2014-11-28 14:25:04 +11:00
2014-11-28 14:27:09 +11:00
2013-08-12 16:10:35 -05:00
2016-02-09 16:54:58 +11:00
2016-02-09 16:54:58 +11:00
2016-03-07 09:31:00 +11:00
2016-03-07 09:30:32 +11:00
2015-10-12 16:02:56 +11:00
2014-10-02 09:17:58 +10:00
2016-03-07 09:34:31 +11:00
2013-08-12 16:56:06 -05:00
2016-01-12 07:04:30 +11:00
2015-01-09 10:48:12 +11:00
2016-03-07 09:34:31 +11:00
2015-02-23 22:38:08 +11:00
2016-02-09 16:54:58 +11:00
2014-11-07 08:30:30 +11:00
2015-10-12 05:19:45 +11:00
2015-07-29 11:51:01 +10:00
2016-01-05 07:41:16 +11:00
2016-03-11 10:21:32 -08:00
2016-03-07 08:40:03 +11:00
2015-10-12 15:59:25 +11:00
2015-10-12 16:04:45 +11:00
2013-05-07 18:45:36 -05:00
2016-03-07 09:34:54 +11:00
2016-03-15 11:44:35 +11:00
2015-03-25 14:57:53 +11:00
2014-04-23 07:11:51 +10:00
2016-03-09 08:15:14 +11:00
2016-01-22 18:04:28 -05:00
2016-03-18 11:42:53 -04:00
2014-11-28 14:27:09 +11:00
2016-02-08 11:27:55 +11:00
2016-02-08 11:27:55 +11:00
2016-02-08 11:27:55 +11:00
2015-06-01 07:15:37 +10:00
2016-02-08 11:27:38 +11:00
2016-02-09 16:54:58 +11:00
2014-09-09 11:58:42 +10:00
2015-10-19 08:42:46 +11:00
2015-10-12 18:21:22 +11:00
2016-03-09 08:18:30 +11:00
2016-03-02 09:58:09 +11:00
2016-01-11 11:34:01 +11:00
2013-10-08 14:53:02 -05:00
2015-10-12 05:19:45 +11:00
2014-09-09 11:56:13 +10:00
2016-03-15 11:42:44 +11:00
2015-10-12 05:15:45 +11:00
2014-11-28 14:27:09 +11:00
2016-02-08 14:40:51 +11:00
2016-02-08 14:59:07 +11:00
2016-02-10 15:01:11 +11:00
2016-02-08 11:27:55 +11:00
2015-08-19 09:51:43 +10:00
2016-02-09 16:54:58 +11:00
2015-08-19 10:01:08 +10:00
2016-03-15 11:42:47 +11:00
2016-03-02 09:58:21 +11:00
2015-12-06 21:34:16 -05:00
2013-05-07 18:45:36 -05:00
9bdd9bd69b