Amadeusz Sławiński
dd9f9cc1e6
ASoC: core: Do not call link_exit() on uninitialized rtd objects ...
On init we have sequence:
for_each_card_prelinks(card, i, dai_link) {
ret = snd_soc_add_pcm_runtime(card, dai_link);
ret = init_some_other_things(...);
if (ret)
goto probe_end:
for_each_card_rtds(card, rtd) {
ret = soc_init_pcm_runtime(card, rtd);
probe_end:
while on exit:
for_each_card_rtds(card, rtd)
snd_soc_link_exit(rtd);
If init_some_other_things() step fails due to error we end up with
not fully setup rtds and try to call snd_soc_link_exit on them, which
depending on contents on .link_exit handler, can end up dereferencing
NULL pointer.
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20230929103243.705433-2-amadeuszx.slawinski@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2023-09-29 14:17:49 +02:00
2023-01-25 09:34:20 +01:00
2023-07-31 23:24:03 +01:00
2023-03-30 17:04:56 +02:00
2017-11-02 11:10:55 +01:00
2023-02-03 12:04:02 +00:00
2019-05-30 11:26:35 -07:00
2008-07-14 09:01:02 +02:00
2019-05-30 11:25:18 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2023-05-23 12:11:21 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2023-08-17 09:24:15 +02:00
2023-07-21 09:37:47 +02:00
2023-08-17 09:24:33 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-02-08 13:00:28 +00:00
2023-07-24 10:59:58 +02:00
2023-07-23 23:40:22 +01:00
2023-01-31 12:10:46 +00:00
2023-08-18 23:41:54 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:37 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:32 -07:00
2023-05-23 18:49:36 +01:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2023-08-23 13:56:40 +01:00
2023-09-01 15:38:29 +02:00
2019-05-30 11:26:35 -07:00
2023-07-17 09:29:07 +02:00
2019-05-30 11:26:35 -07:00
2021-07-19 16:17:14 +02:00
2019-05-30 11:26:35 -07:00
2023-06-13 07:42:08 +02:00
2021-08-05 08:24:17 +02:00
2021-10-15 16:10:41 +01:00
2020-07-07 11:59:59 +02:00
2017-11-02 11:10:55 +01:00
2023-07-18 14:22:19 +02:00
2019-02-08 16:58:59 +01:00
2019-05-24 17:27:10 +02:00
2018-07-17 22:25:48 +02:00
2023-04-06 16:45:34 +01:00
2020-01-13 13:40:41 +01:00
2022-02-11 15:18:56 +01:00
2023-08-07 23:09:46 +01:00
2022-12-05 14:05:18 +00:00
2023-07-18 14:22:17 +02:00
2022-12-02 14:07:12 +00:00
2023-08-17 09:24:01 +02:00
2019-05-30 11:26:35 -07:00
2023-08-08 14:45:45 +02:00
2020-01-05 16:14:26 +01:00
2022-05-17 11:58:04 +01:00
2022-09-20 12:25:03 +01:00
2022-04-12 12:19:05 +02:00
2022-07-05 13:00:49 +01:00
2012-01-30 21:50:55 +00:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2022-08-24 08:00:26 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2020-07-19 20:49:25 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2017-11-02 11:10:55 +01:00
2021-06-08 17:05:41 +02:00
2019-05-30 11:26:35 -07:00
2020-09-09 18:43:07 +02:00
2023-03-24 14:52:58 +01:00
2023-08-18 12:19:19 +02:00
2019-05-30 11:26:35 -07:00
2022-05-07 22:55:48 +02:00
2023-08-17 09:24:08 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-11-05 17:25:17 +00:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2023-08-17 15:10:11 +01:00
2023-08-17 15:10:12 +01:00
2023-08-17 15:10:13 +01:00
2023-08-17 15:10:13 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2022-11-28 13:04:24 +00:00
2023-05-23 12:11:33 +02:00
2023-05-23 12:11:21 +02:00
2020-01-03 09:24:19 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-06-19 17:09:55 +02:00
2018-08-02 10:56:59 +01:00
2023-07-17 06:15:47 +01:00
2018-07-02 10:52:47 +01:00
2017-11-13 15:45:57 +01:00
2023-05-15 20:11:58 +09:00
2023-08-03 17:31:28 +01:00
2023-04-17 12:57:26 +01:00
2023-09-01 15:38:49 +02:00
2023-08-14 13:10:35 +01:00
2023-08-15 13:25:55 +01:00
2023-05-19 02:31:14 +09:00
2020-11-30 12:54:02 +00:00
2020-12-09 12:13:38 +00:00
2023-01-30 16:56:41 +00:00
2023-09-29 14:17:49 +02:00
2023-04-04 12:42:33 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:41 -07:00
2023-06-19 12:59:29 +01:00
2023-06-19 12:59:29 +01:00
2023-06-19 12:59:29 +01:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:35 -07:00
2020-09-09 18:32:52 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:35 -07:00
2019-06-05 17:37:07 +02:00
2019-06-19 17:09:55 +02:00
2023-06-23 09:56:11 +02:00
2023-06-12 18:22:26 +02:00
2023-08-24 10:03:17 +02:00
2019-05-30 11:26:35 -07:00
2020-01-03 09:24:20 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:32 -07:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-10-25 11:06:57 +01:00
2019-05-30 11:26:32 -07:00
2020-06-15 20:58:33 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:35 -07:00
dd9f9cc1e6