From 258aabbde0dafd60f188da7b45c77d080f39eb96 Mon Sep 17 00:00:00 2001
From: Redstone1024 <2824517378@qq.com>
Date: Tue, 5 Nov 2024 22:41:45 +0800
Subject: [PATCH] fix(typetraits): fix CCommonType is incorrect for void

---
 Redcraft.Utility/Source/Public/TypeTraits/Common.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/Redcraft.Utility/Source/Public/TypeTraits/Common.h b/Redcraft.Utility/Source/Public/TypeTraits/Common.h
index 4cee50a..581dbfb 100644
--- a/Redcraft.Utility/Source/Public/TypeTraits/Common.h
+++ b/Redcraft.Utility/Source/Public/TypeTraits/Common.h
@@ -57,7 +57,7 @@ template <typename T, typename U> concept CConditionalType = requires { typename
 template <typename T, typename U> requires (CDecayed<T, U> && !CBasicCommonType<T, U> && CConditionalType<T, U>)
 struct TCommonTypeImpl<T, U> { using Type = TDecay<decltype(false ? DeclVal<T>() : DeclVal<U>())>; };
 
-// Otherwise, if TDecay<decltype(false ? DeclVal<CRT>() : DeclVal<CRU>())> is a valid Type, 
+// Otherwise, if TDecay<decltype(false ? DeclVal<CRT>() : DeclVal<CRU>())> is a valid Type,
 // where CRT and CRU are const TRemoveReference<T>& and const TRemoveReference<U>& respectively, the member Type denotes that Type
 template <typename T, typename U> concept CConditionalCRefType = requires { typename TDecay<decltype(false ? DeclVal<const TRemoveReference<T>&>() : DeclVal<const TRemoveReference<U>&>())>; };
 template <typename T, typename U> requires (CDecayed<T, U> && !CBasicCommonType<T, U> && !CConditionalType<T, U> && CConditionalCRefType<T, U>)
@@ -182,9 +182,8 @@ concept CCommonReference =
 
 template <typename... Ts>
 concept CCommonType =
-	requires { typename TCommonType<Ts...>; }
-	&& (true && ... && CConstructibleFrom<TCommonReference<Ts...>, Ts&&>)
-	&& CCommonReference<const Ts&...> && CCommonReference<TCommonType<Ts...>&, TCommonReference<const Ts&...>>;
+	requires { typename TCommonType<Ts...>; (static_cast<TCommonType<Ts...>>(DeclVal<Ts>()), ...); }
+	&& CCommonReference<const TAddLValueReference<Ts>...> && CCommonReference<TCommonReference<TCommonType<Ts...>>, TCommonReference<const TAddLValueReference<Ts>...>>;
 
 NAMESPACE_MODULE_END(Utility)
 NAMESPACE_MODULE_END(Redcraft)